Sheffield | May-2025 | WALEED-YAHYA SALIH-TAHA | Sprint-3 #652

Bluejay600 · 2025-07-11T01:28:15Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Sprint-3 is mainly about implementing, rewriting, practicing and and testing functions.

Questions

Ask any questions you have for your reviewer.

2. identified obtuse angle and it's function 3. identified stright angle and it's function 4. identified reflex anglewith it's function.

…han 180 degrees.

2. Identified Obtuse angles when it's greater than 90 degrees and less than 180, and added a line to test the function. 3. added a line to test all the if conditions in the program.

…odule-Structuring-and-Testing-Data into Sprint3-Test-branch

… my function.

…to 360 degrees.

… degree.

… line code to check the result.

…o it to handle diffrent type of the cards.

…odule-Structuring-and-Testing-Data into Sprint3-Test-branch

2. tested other scenarios like Zero numerator

…mplement. 2. Added some test examples.

…han 360.

2. handled Ace (A)

2.

… a positive integer count.

…mbers as needed.

…odule-Structuring-and-Testing-Data into Sprint3-Test-branch

cjyuan

Sprint-3/4-stretch-investigate/password-validator.js
Sprint-3/4-stretch-investigate/password-validator.test.js

I noticed the code in the above two files were partially modified buy they are not yet fully implemented. Since "stretch" exercises are optional, I will only comment when they are fully implemented.

cjyuan · 2025-07-15T23:26:35Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

+console.log(getAngleType(90));   // Right angle
+console.log(getAngleType(135));  // Obtuse angle
+console.log(getAngleType(180));  // Straight angle
+console.log(getAngleType(270));  // Reflex angle
+console.log(getAngleType(0));    // Invalid angle
+console.log(getAngleType(360));  // Invalid angle
+console.log(getAngleType(-10));  // Invalid angle


Unused code or code used solely for development purposes should be removed or, at the very least, commented out with clear justification.

cjyuan · 2025-07-15T23:28:09Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

+const zeroNumerator = isProperFraction(0, 5);
+assertEquals(zeroNumerator, true); // ✅ should pass


Technically 0 is not considered a proper fraction. :)

cjyuan · 2025-07-15T23:31:14Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+    const rank = card.slice(0, -1); // Get the rank (everything except the last character)
+    if (rank === "A") return 11;
+    if (["J", "Q", "K"].includes(rank)) return 10;
+    if (rank >= "2" && rank <= "9") return parseInt(rank, 10);


Strings are compared differently in the JS language.

Does your function return the value you expected from each of the following function calls?

getCardValue("333♠"); getCardValue("3.1416♠"); getCardValue("3ABC♠");

cjyuan · 2025-07-15T23:32:08Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 5 for 5 of Hearts", () => {
+    const fiveofHearts = getCardValue("5♥");
+    expect(fiveofHearts).toEqual(5);
+});
+


When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual card, we will need about 53 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples.

For example, one possible category for getCardValue() is, "should return the value of number cards (2-10)", and we can prepare the test as

test("should return the value of number cards (2-10)", () => { expect(getCardValue("2♣︎")).toEqual(2); expect(getCardValue("5♠")).toEqual(5); expect(getCardValue("10♥")).toEqual(5); // Note: We could also use a loop to check all values from 2 to 10. });

cjyuan · 2025-07-15T23:33:35Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 10 for Jack of Diamonds", () => {
+    const jackOfDiamonds = getCardValue("J♦");
+    expect(jackOfDiamonds).toEqual(10);
+});
+test("should return 10 for Queen of Clubs", () => {
+    const queenOfClubs = getCardValue("Q♣");
+    expect(queenOfClubs).toEqual(10);
+});
+test("should return 10 for King of Spades", () => {
+    const kingOfSpades = getCardValue("K♠");
+    expect(kingOfSpades).toEqual(10);
+});


We could also combine these tests into one under the category "should return 10 for face cards (J, Q, K)".

cjyuan · 2025-07-15T23:36:18Z

Sprint-3/3-mandatory-practice/implement/count.test.js

+function countChar(stringOfCharacters, findCharacter) {
+    // Initialize a counter
+    let count = 0;

-// Scenario: Multiple Occurrences
-// Given the input string str,
-// And a character char that may occur multiple times with overlaps within str (e.g., 'a' in 'aaaaa'),
-// When the function is called with these inputs,
-// Then it should correctly count overlapping occurrences of char (e.g., 'a' appears five times in 'aaaaa').
+    // Loop through the string
+    for (let char of stringOfCharacters) {
+        if (char === findCharacter) {
+            count++;
+        }
+    }


Why defined another countChar() function in this script? The code in this script is supposed to test the function implemented in Sprint-3/3-mandatory-practice/implement/count.test.js.

cjyuan · 2025-07-15T23:37:51Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

+function getOrdinalNumber(num) {
+
+module.exports = getOrdinalNumber;


The statement module.exports = ... should be placed outside of any function block; usually at the end of the file.

cjyuan · 2025-07-15T23:39:07Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

+        return "1st";
+    } else if (num === 2) {
+        return "2nd";
+    } else if (num === 3) {
+        return "3rd";


Why not just rely on the code at lines 20-25 to handle these three specific numbers?

cjyuan · 2025-07-15T23:39:43Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

+test("should return '2nd' for 2", () => {
+    expect(getOrdinalNumber(2)).toEqual("2nd");
+    });


To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

Can you update the tests in this script so that they can cover all valid integers?

cjyuan · 2025-07-15T23:41:20Z

Sprint-3/3-mandatory-practice/implement/repeat.js

Why not delete the code at lines 1-3?

Bluejay600 added 30 commits June 14, 2025 13:54

1. identified acute angel and it's function

56e3dbc

2. identified obtuse angle and it's function 3. identified stright angle and it's function 4. identified reflex anglewith it's function.

Identified Obtuse Angles when the angle is greater than 90 and less t…

d4a0730

…han 180 degrees.

Identified Stright Angle s when the angle is 180 degree

f6cd051

Identified stright angle when the angle is greater than 180

59a1e19

1. Added 4 if conditions to the function getAngleType(angle).

a0004a8

2. Identified Obtuse angles when it's greater than 90 degrees and less than 180, and added a line to test the function. 3. added a line to test all the if conditions in the program.

Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…

c7772a6

…odule-Structuring-and-Testing-Data into Sprint3-Test-branch

1. Added a test line to each case.

eb50828

added a false return value to handle the case for improper fractions

b797a92

1. wrote test, and make it pass, to build solution up methodically.

f5f36f5

Added 4 if conditions in the function getAngleType(angle) to build up…

a467519

… my function.

Added a return invalid angle to handle angles outside the range of 0 …

18a93a1

…to 360 degrees.

Identified and corrected the right angle when the angle is exactly 90…

3523e59

… degree.

Added assertion to the negative fraction to equal true.

d6a2edf

Added assertion to the equal numerator and denominator, and a console…

67a05da

… line code to check the result.

Stretched creating Zero Numerator check assertion.

5a1570a

implemented the function getCardValue(card) and added if conditions t…

61decd0

…o it to handle diffrent type of the cards.

wrote the test code and added a line to pass the test.

8e295aa

fixed the getCardValue function to handel card 10

4b2e240

Handled face Cards (J, Q, K) to return the value 10.

a1f0f58

Added a code to handle a card with invalid rank (Z)

ec30fb1

Replaced the code my code in 1-key-implement and tested

a0595c0

Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…

eda20da

…odule-Structuring-and-Testing-Data into Sprint3-Test-branch

fixed acute angle test code to make the description clear.

b0904d1

removed the duplicated test for Acute angle

fca4456

1. removed unwanted spaces.

71bac2d

2. tested other scenarios like Zero numerator

1. removed the function and replaced with the function in the 1-key-i…

3e96df9

…mplement. 2. Added some test examples.

1. Replaced the comment and added angle 45 in the function.

2b1c9be

1. Identified Obtuse angles (90 < angle < 180 )

3a5be71

1. Identified reflex angles when angle is greater than 180 and less t…

da42c37

…han 360.

1. Identified Invalid angle when it's less than 0 or greater than 360.

c9b0ff6

Bluejay600 and others added 20 commits July 10, 2025 01:48

1. identified right angle.

fd37f69

1. removed the extra space between test and the opening parenthesis:

f242d6a

added my completed function from key-implement.

fee695d

identified improper fractions to case 2.

abcdfbf

replaced the whole code with the one in card value in key-implement.

af20de9

Handled Number Cards (2-10):

7076fc0

1. Handled Face Cards (J, Q, K):

9ef7886

2. handled Ace (A)

handled invalid cards.

1b10f2d

joined the two Ace functions in one.

7d4ba19

initialized counter to keep track of occurrences

49b7c00

1. initialized a counter for the function.

f85e00c

2.

Added test tarbet string

f3973af

added a test to Handle count of 0.

3b2251a

Added a test to handle a negative count.

58a71c3

Implemented a function repeat that that given a target string str and…

1a74ee8

… a positive integer count.

Function was handling the case for 1st. I expanded to handle other nu…

ebc99d8

…mbers as needed.

implemented case one and case 2 testing.

af1e3ca

Merge branch 'CodeYourFuture:main' into Sprint3-Test-branch

cab246a

Played computer with the password validator

a64cee4

Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…

a451aeb

…odule-Structuring-and-Testing-Data into Sprint3-Test-branch

Bluejay600 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Participant to add when requesting review labels Jul 11, 2025

cjyuan reviewed Jul 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sheffield | May-2025 | WALEED-YAHYA SALIH-TAHA | Sprint-3 #652

Sheffield | May-2025 | WALEED-YAHYA SALIH-TAHA | Sprint-3 #652

Uh oh!

Bluejay600 commented Jul 11, 2025 •

edited

Loading

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

cjyuan Jul 15, 2025

Uh oh!

Uh oh!

		const zeroNumerator = isProperFraction(0, 5);
		assertEquals(zeroNumerator, true); // ✅ should pass

		function getOrdinalNumber(num) {

		module.exports = getOrdinalNumber;

Uh oh!

Sheffield | May-2025 | WALEED-YAHYA SALIH-TAHA | Sprint-3 #652

Are you sure you want to change the base?

Sheffield | May-2025 | WALEED-YAHYA SALIH-TAHA | Sprint-3 #652

Uh oh!

Conversation

Bluejay600 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bluejay600 commented Jul 11, 2025 •

edited

Loading